Adds browser preferences to configure first-run flow on Windows 8.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 
 namespace prefs {
 
@@ skipping 814 matching lines @@
 const char kPluginsAllowOutdated[] = "plugins.allow_outdated";
 
 // Boolean that indicates whether plugins that require authorization should
 // be always allowed or not.
 const char kPluginsAlwaysAuthorize[] = "plugins.always_authorize";
 
 // Boolean that indicates whether we should check if we are the default browser
 // on start-up.
 const char kCheckDefaultBrowser[] = "browser.check_default_browser";
 
-// TODO(motek): Remove this once a firm decision is made regarding how the UI
-// should be presented.
-const char kDefaultBrowserFlowDialog[] = "browser.set_default_flow_dialog";
+const char kCheckDefaultBrowserOnFirstRun[] =

[grt (UTC plus 2), 2012/07/05 17:16:09]

please make the names of the constants for these new prefs match the values. 
for example, kFirstRunCheckDefaultBrowser or
browser.check_default_browser_on_first_run for this one.

[motek., 2012/07/05 20:22:26]

Done.

+    "browser.first_run_check_default_browser";
+
+#if defined(OS_WIN)
+// Boolean that indicates it is OK to enter modal 'set-as-default-browser'
+// dialog. Relevant in Windows 8 first-run context only.
+const char kDefaultBrowserFlowDialogEnabled[] =
+    "browser.set_default_flow_dialog_enabled";
+
+// By default, setting Chrome as deafult during first run on Windows 8 will

[grt (UTC plus 2), 2012/07/05 17:16:09]

deafult -> default

[motek., 2012/07/05 20:22:26]

This has been moved to master_preferences_constants,

+// trigger shutting down the current instance and spawning a new (Metro)
+// Chrome. This boolean flag supresses this behaviour.

[grt (UTC plus 2), 2012/07/05 17:16:09]

since "flag" has special meaning in Chrome, i suggest using a different noun
here ("preference"?).

[motek., 2012/07/05 20:22:26]

Done.

+const char kSuppressSwitchToMetroModeOnSetDefault[] =
+    "browser.suppress_metro_switch_on_set_default";
+#endif
 
 // Policy setting whether default browser check should be disabled and default
 // browser registration should take place.
 const char kDefaultBrowserSettingEnabled[] =
     "browser.default_browser_setting_enabled";
 
 #if defined(OS_MACOSX)
 // Boolean that indicates whether the application should show the info bar
 // asking the user to set up automatic updates when Keystone promotion is
 // required.
@@ skipping 1129 matching lines @@
 const char kNetworkProfileLastWarningTime[] =
     "network_profile.last_warning_time";
 
 #if defined(OS_MACOSX)
 // A timestamp of when the obsolete OS infobar was last shown to a user on 10.5.
 const char kMacLeopardObsoleteInfobarLastShown[] =
     "mac_105_obsolete_infobar_last_shown";
 #endif  // defined(OS_MACOSX)
 
 }  // namespace prefs