Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: runtime/vm/debugger_x64.cc

Issue 10702068: Implement ActivationFrame::GetLocalVarValue on x64. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger_x64.cc
diff --git a/runtime/vm/debugger_x64.cc b/runtime/vm/debugger_x64.cc
index 2928ee9edfb88d68116adb6434c6bb20dee6db9c..6e64d859a644f289a43695b38b884de68fa6b553 100644
--- a/runtime/vm/debugger_x64.cc
+++ b/runtime/vm/debugger_x64.cc
@@ -12,10 +12,11 @@
namespace dart {
-// TODO(hausner): Implement this. For now just return null instead
-// of hitting UNIMPLEMENTED.
+// TODO(hausner): Handle captured variables.
RawInstance* ActivationFrame::GetLocalVarValue(intptr_t slot_index) {
- return Instance::null();
+ uword var_address = fp() + slot_index * kWordSize;
+ return reinterpret_cast<RawInstance*>(
+ *reinterpret_cast<uword*>(var_address));
}
« runtime/vm/debugger_api_impl_test.cc ('K') | « runtime/vm/debugger_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698