Issue 10702068: Implement ActivationFrame::GetLocalVarValue on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702068: Implement ActivationFrame::GetLocalVarValue on x64. (Closed)

Created:
8 years, 5 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 5 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement ActivationFrame::GetLocalVarValue on x64. R=iposva@google.com BUG=3961 TEST=Debug_ExprClosureBreakpoint Committed: https://code.google.com/p/dart/source/detail?r=9334

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -19 lines)			Patch
	M	runtime/vm/debugger_api_impl_test.cc	View		3 chunks	+60 lines, -16 lines	1 comment	Download
	M	runtime/vm/debugger_x64.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 5 months ago (2012-07-02 21:10:38 UTC) #2

LGTM with comment.

-Ivan

https://chromiumcodereview.appspot.com/10702068/diff/1/runtime/vm/debugger_ap...
File runtime/vm/debugger_api_impl_test.cc (left):

https://chromiumcodereview.appspot.com/10702068/diff/1/runtime/vm/debugger_ap...
runtime/vm/debugger_api_impl_test.cc:623: 
?

Expand Messages | Collapse Messages