Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: runtime/vm/store_buffer.cc

Issue 10702067: - Separate store buffer data in the isolate into the StoreBufferBlock and (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/store_buffer.cc
===================================================================
--- runtime/vm/store_buffer.cc (revision 9305)
+++ runtime/vm/store_buffer.cc (working copy)
@@ -23,4 +23,28 @@
return false;
}
+
+StoreBuffer::~StoreBuffer() {
+ DedupSet* current = dedup_sets_;
+ while (current != NULL) {
+ DedupSet* next = current->next_;
+ delete current;
+ current = next;
+ }
siva 2012/07/02 20:57:42 dedup_sets_ = NULL;
Ivan Posva 2012/07/03 00:10:24 Done.
+}
+
+
+void StoreBuffer::AddPointer(uword address) {
siva 2012/07/02 20:57:42 ASSERT(dedup_sets_ != NULL);
Ivan Posva 2012/07/03 00:10:24 Done.
+ if (!dedup_sets_->set_->Add(address)) {
+ // TODO(iposva): Limit growth of deduplication sets until the rest of the
+ // mechanism is hooked up.
+ delete dedup_sets_;
+ dedup_sets_ = NULL;
+
+ DedupSet* fresh_element = new DedupSet();
+ fresh_element->next_ = dedup_sets_;
+ dedup_sets_ = fresh_element;
+ }
+}
+
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698