Issue 10702060: Plug memory leak in Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702060: Plug memory leak in Isolate. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Plug memory leak in Isolate. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11965

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : init data_ #

Total comments: 3

Patch Set 4 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	src/v8threads.h	View	1 2 3	3 chunks	+4 lines, -1 line	0 comments	Download
	M	src/v8threads.cc	View	1 2 3	3 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-02 12:11:43 UTC) #2

LGTM with nits.

https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.cc
File src/v8threads.cc (right):

https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.cc#ne...
src/v8threads.cc:1: // Copyright 2008 the V8 project authors. All rights
reserved.
nit: 2012

https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.cc#ne...
src/v8threads.cc:249: if (data_ != NULL) DeleteArray<char>(data_);
I think we don't need the NULL check.

https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.h
File src/v8threads.h (right):

https://chromiumcodereview.appspot.com/10702060/diff/5001/src/v8threads.h#new...
src/v8threads.h:1: // Copyright 2008 the V8 project authors. All rights
reserved.
nit: 2012

Expand Messages | Collapse Messages