Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 10702048: Remove the code to wait on disconnected child processes to get the exit code. This was done in r101… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | content/browser/browser_child_process_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
===================================================================
--- chrome/browser/metrics/metrics_service.cc (revision 145643)
+++ chrome/browser/metrics/metrics_service.cc (working copy)
@@ -680,8 +680,7 @@
content::RenderProcessHost* host =
content::Source<content::RenderProcessHost>(source).ptr();
LogRendererCrash(
- host, process_details->status, process_details->exit_code,
- process_details->was_alive);
+ host, process_details->status, process_details->exit_code);
}
break;
@@ -1565,8 +1564,7 @@
void MetricsService::LogRendererCrash(content::RenderProcessHost* host,
base::TerminationStatus status,
- int exit_code,
- bool was_alive) {
+ int exit_code) {
Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
ExtensionService* service = profile->GetExtensionService();
bool was_extension_process =
@@ -1589,19 +1587,14 @@
UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashes",
was_extension_process ? 2 : 1);
- if (was_alive) {
- UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashesWasAlive",
- was_extension_process ? 2 : 1);
- }
} else if (status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED) {
UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKills",
was_extension_process ? 2 : 1);
- if (was_alive) {
- UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKillsWasAlive",
+ } else if (status == base::TERMINATION_STATUS_STILL_RUNNING) {
+ UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.DisconnectedAlive",
was_extension_process ? 2 : 1);
}
}
-}
void MetricsService::LogRendererHang() {
IncrementPrefValue(prefs::kStabilityRendererHangCount);
@@ -1881,7 +1874,7 @@
// static
bool MetricsService::IsPluginProcess(content::ProcessType type) {
- return (type == content::PROCESS_TYPE_PLUGIN ||
+ return (type == content::PROCESS_TYPE_PLUGIN||
type == content::PROCESS_TYPE_PPAPI_PLUGIN ||
type == content::PROCESS_TYPE_PPAPI_BROKER);
}
« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | content/browser/browser_child_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698