Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 10701177: Make content shell on android support relaunching. (Closed)

Created:
8 years, 5 months ago by Ted C
Modified:
8 years, 4 months ago
Reviewers:
Yaron, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, cjhopman, Jesse Greenwald
Visibility:
Public.

Description

Make content shell on android support relaunching. Without this change, the content shell would crash after pressing back to the home screen and relaunching. The two problems this fixes are: 1.) It was trying to initialize the command line even though it already was init'ed before. 2.) The shell wasn't being recreated because it is done during process start and the process is already running. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148365

Patch Set 1 #

Patch Set 2 : Rebase and removed unnecessary content:: namespacing. #

Messages

Total messages: 9 (0 generated)
Ted C
8 years, 5 months ago (2012-07-13 17:53:54 UTC) #1
Jay Civelli
lgtm
8 years, 5 months ago (2012-07-23 21:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10701177/4001
8 years, 5 months ago (2012-07-24 23:42:22 UTC) #3
commit-bot: I haz the power
Presubmit check for 10701177-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-24 23:42:28 UTC) #4
Ted C
@Yaron, looks like I'll need an lgtm from you as well.
8 years, 5 months ago (2012-07-24 23:43:13 UTC) #5
Yaron
rubberstamping. Jay should be in OWNERS
8 years, 5 months ago (2012-07-24 23:48:37 UTC) #6
Yaron
LGTM
8 years, 5 months ago (2012-07-24 23:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10701177/4001
8 years, 4 months ago (2012-07-25 16:39:39 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-07-25 18:12:21 UTC) #9
Change committed as 148365

Powered by Google App Engine
This is Rietveld 408576698