Send request to show print system dialog to Metro.

Send request to show print system dialog to Metro.

BUG=134256
TEST=Make sure there are no way to open the system's print dialog in Chrome when running in Metro. The print device charm should be shown instead.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146399

[MAD, 2012-07-12 13:44:38]

Please... :-)

BYE
MAD

[Albert Bodenhamer, 2012-07-12 16:32:10]

lgtm

http://codereview.chromium.org/10701155/diff/1/printing/printing_context_win.cc
File printing/printing_context_win.cc (right):

http://codereview.chromium.org/10701155/diff/1/printing/printing_context_win....
printing/printing_context_win.cc:229: typedef void (*MetroShowPrintUI)();
Nit: Is the prototype for MetroShowPrintUI defined in a header somewhere?

Longer term: Does it make sense to build a wrapper class around the the Metro
module that will either delay load or dynamically load the DLL and fail
gracefully?  Exposing all of the dynamic load code in callers adds clutter and
bloat.

[MAD, 2012-07-12 17:16:14]

Thanks!...

http://codereview.chromium.org/10701155/diff/1/printing/printing_context_win.cc
File printing/printing_context_win.cc (right):

http://codereview.chromium.org/10701155/diff/1/printing/printing_context_win....
printing/printing_context_win.cc:229: typedef void (*MetroShowPrintUI)();
On 2012/07/12 16:32:10, Albert Bodenhamer wrote:
> Nit: Is the prototype for MetroShowPrintUI defined in a header somewhere?
> 
> Longer term: Does it make sense to build a wrapper class around the the Metro
> module that will either delay load or dynamically load the DLL and fail
> gracefully?  Exposing all of the dynamic load code in callers adds clutter and
> bloat.

There's work in progress for this... Not quite ready yet...

[commit-bot: I haz the power, 2012-07-12 17:16:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10701155/1

[commit-bot: I haz the power, 2012-07-12 18:38:32]

Change committed as 146399