third_party/smhasher/README.chromium - Issue 10701151: DuplicateContentResourceHandler to monitor resources and track how many times th…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/smhasher/README.chromium

Issue 10701151: DuplicateContentResourceHandler to monitor resources and track how many times th… (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 Name: SMHasher	1 Name: SMHasher

2 URL: http://code.google.com/p/smhasher/	2 URL: http://code.google.com/p/smhasher/

3 Version: 0	3 Version: 0

4 Revision: 136	4 Revision: 146
	gavinp 2012/07/20 01:37:59 Does the fact that you had to make this change cal Does the fact that you had to make this change call into question this text file? Are there other examples of files like this? I'm not happy seeing this change. frankwang 2012/07/20 04:50:00 There was a pre-submit error that said I should ch Show quoted text On 2012/07/20 01:37:59, gavinp wrote: > Does the fact that you had to make this change call into question this text > file? Are there other examples of files like this? I'm not happy seeing this > change. There was a pre-submit error that said I should change the README to the revision I am using. I am currently using 146 so that I can have PMurHash.h. Let me know what I should do for this. gavinp 2012/07/20 11:38:46 It's fine. I just don't get why we have these file Show quoted text On 2012/07/20 04:50:00, frankwang wrote: > On 2012/07/20 01:37:59, gavinp wrote: > > Does the fact that you had to make this change call into question this text > > file? Are there other examples of files like this? I'm not happy seeing this > > change. > There was a pre-submit error that said I should change the README to the > revision I am using. I am currently using 146 so that I can have PMurHash.h. Let > me know what I should do for this. It's fine. I just don't get why we have these files. Either we don't need this, or we don't need the DEPS file. But that's out of scope for our review.
5 License: MIT (SMHasher), Public Domain (MurmurHash)	5 License: MIT (SMHasher), Public Domain (MurmurHash)

6 License File: LICENSE	6 License File: LICENSE

7 Security Critical: yes	7 Security Critical: yes

8	8

9 Description:	9 Description:

10 This is a library containing the MurmurHash3 function, and a hashing function	10 This is a library containing the MurmurHash3 function, and a hashing function

11 test suite.	11 test suite.

12	12

OLD	NEW

« content/browser/renderer_host/resource_dispatcher_host_impl.cc ('K') | « content/content_browser.gypi ('k') | third_party/smhasher/smhasher.gyp » ('j') | no next file with comments »