Remove duplicated LChunk code.

Remove duplicated LChunk code.

Divide the LChunk class into an arch-independent LChunkBase and an
arch-dependent LChunk which inherits from LChunkBase.

BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=12045

[danno, 2012-07-11 14:08:14]

LGTM with comments. Please make sure this compiles and works on all platforms.

http://codereview.chromium.org/10701141/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10701141/diff/1/src/hydrogen.cc#newcode9269
src/hydrogen.cc:9269: void HTracer::TraceLithium(const char* name, LChunkBase*
chunk_base) {
I think you omit the change of chunk to chunk_base. I don't think it improves
readability. Here and elsewhere.

http://codereview.chromium.org/10701141/diff/1/src/lithium.cc
File src/lithium.cc (right):

http://codereview.chromium.org/10701141/diff/1/src/lithium.cc#newcode346
src/lithium.cc:346: 
nit: should be two empty lines

[Yang, 2012-07-11 14:08:26]

On 2012/07/11 14:00:12, sanjoy wrote:

LGTM if code compiles and tests pass.