Issue 10701134: Revert "Make EventBindings use static routed methods."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701134: Revert "Make EventBindings use static routed methods." (Closed)

Created:
8 years, 5 months ago by koz (OOO until 15th September)

Modified:
8 years, 5 months ago

Reviewers:
kalman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "Make EventBindings use static routed methods." (r145634) The crashes that it was hoped this patch would prevent didn't stop, and the actual bug was fixed in r145842. BUG=136232 TBR=kalman@chomium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146012

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -53 lines)			Patch
M	chrome/renderer/extensions/event_bindings.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	15 chunks	+48 lines, -50 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10701134/1

8 years, 5 months ago (2012-07-10 23:55:29 UTC) #1

Change committed as 146012