Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10701131: Stop passing location argument to run time calls, since it is stored in the pc (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 9532)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -182,7 +182,6 @@
__ CompareObject(obj, compiler->bool_false());
__ j(EQUAL, &done, Assembler::kNearJump);
- __ pushl(Immediate(Smi::RawValue(token_pos()))); // Source location.
__ pushl(obj); // Push the source object.
compiler->GenerateCallRuntime(cid(),
token_pos(),
@@ -1061,7 +1060,6 @@
// Push the result place holder initialized to NULL.
__ PushObject(Object::ZoneHandle());
- __ pushl(Immediate(Smi::RawValue(token_pos())));
__ PushObject(cls);
__ pushl(type_arguments);
__ pushl(instantiator_type_arguments);
@@ -1069,9 +1067,9 @@
token_pos(),
try_index(),
kAllocateObjectWithBoundsCheckRuntimeEntry);
- // Pop instantiator type arguments, type arguments, class, and
+ // Pop instantiator type arguments, type arguments, and class.
// source location.
- __ Drop(4);
+ __ Drop(3);
__ popl(result); // Pop new instance.
}

Powered by Google App Engine
This is Rietveld 408576698