Issue 10701130: Fix buffered range reporting for ChunkDemuxer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701130: Fix buffered range reporting for ChunkDemuxer (Closed)

Created:
8 years, 5 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 5 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix buffered range reporting for ChunkDemuxer BUG=None TEST=PipelineIntegrationTest, BasicPlayback_MediaSource Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146127

Patch Set 1 : . #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -10 lines)			Patch
M	media/base/pipeline.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/chunk_demuxer.cc	View	1 chunk	+6 lines, -8 lines	2 comments	Download
M	media/filters/pipeline_integration_test.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

lgtm http://codereview.chromium.org/10701130/diff/7001/media/filters/chunk_demuxer.cc File media/filters/chunk_demuxer.cc (left): http://codereview.chromium.org/10701130/diff/7001/media/filters/chunk_demuxer.cc#oldcode726 media/filters/chunk_demuxer.cc:726: if (duration_ > TimeDelta() && duration_ != kInfiniteDuration()) ...

8 years, 5 months ago (2012-07-10 23:11:12 UTC) #2

acolwell GONE FROM CHROMIUM

8 years, 5 months ago (2012-07-10 23:19:30 UTC) #3

http://codereview.chromium.org/10701130/diff/7001/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (left):

http://codereview.chromium.org/10701130/diff/7001/media/filters/chunk_demuxer...
media/filters/chunk_demuxer.cc:726: if (duration_ > TimeDelta() && duration_ !=
kInfiniteDuration()) {
On 2012/07/10 23:11:12, Ami Fischman wrote:
> Do you want to DCHECK these during init?
No. These were just here for the old byte range code so we didn't divide by
something insane.

Expand Messages | Collapse Messages