Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 10701125: Bring back VERSION_SERVER_2003 to distinguish Server 2003 and XP Pro x64 from regular XP. (Closed)

Created:
8 years, 5 months ago by grt (UTC plus 2)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Bring back VERSION_SERVER_2003 to distinguish Server 2003 and XP Pro x64 from regular XP. BUG=135388 TEST=run chrome on Server 2003 SP2 x86. TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M base/win/windows_version.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/win/windows_version.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
I'm baaaaack. Carlos: please check for correctness. Brett: please OWNERsify.
8 years, 5 months ago (2012-07-10 18:39:18 UTC) #1
brettw
I have no idea if this is right, deferring correctness to Carlos. LGTM
8 years, 5 months ago (2012-07-10 21:16:53 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
8 years, 5 months ago (2012-07-11 00:16:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10701125/1
8 years, 5 months ago (2012-07-11 02:45:33 UTC) #4
commit-bot: I haz the power
Presubmit check for 10701125-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-11 02:45:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10701125/1
8 years, 5 months ago (2012-07-11 02:54:16 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 04:07:42 UTC) #7
Change committed as 146054

Powered by Google App Engine
This is Rietveld 408576698