Issue 10701116: Sync preparser and parser wrt syntax error in switch..case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701116: Sync preparser and parser wrt syntax error in switch..case. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Sync preparser and parser wrt syntax error in switch..case. R=jkummerow@chromium.org BUG=v8:2210 TEST=test-parsing/ParserSync Committed: https://code.google.com/p/v8/source/detail?r=12036

Patch Set 2 : Addressed comment #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	src/preparser.cc	View	1	1 chunk	+8 lines, -5 lines	0 comments	Download
	M	test/cctest/test-parsing.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. http://chromiumcodereview.appspot.com/10701116/diff/1/src/preparser.cc File src/preparser.cc (right): http://chromiumcodereview.appspot.com/10701116/diff/1/src/preparser.cc#newcode605 src/preparser.cc:605: Expect(i::Token::COLON, CHECK_OK); nit: The "Expect(...COLON...)" line is in ...

8 years, 5 months ago (2012-07-10 18:46:08 UTC) #2

Yang

8 years, 5 months ago (2012-07-11 07:44:31 UTC) #3

On 2012/07/10 18:46:08, Jakob wrote:
> LGTM.
> 
> http://chromiumcodereview.appspot.com/10701116/diff/1/src/preparser.cc
> File src/preparser.cc (right):
> 
>
http://chromiumcodereview.appspot.com/10701116/diff/1/src/preparser.cc#newcod...
> src/preparser.cc:605: Expect(i::Token::COLON, CHECK_OK);
> nit: The "Expect(...COLON...)" line is in both the if and the else blocks, so
> you could move it out and put it after line 609, but I don't mind either way.

Good point.

Expand Messages | Collapse Messages

Issue 10701116: Sync preparser and parser wrt syntax error in switch..case. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages