Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10701114: Add UI string that is used in the website settings popup to display labels for site permissions. (Closed)

Created:
8 years, 5 months ago by markusheintz_
Modified:
8 years, 5 months ago
Reviewers:
Patrick Dubroy
CC:
chromium-reviews
Visibility:
Public.

Description

Add UI string that is used in the website settings popup to display labels for site permissions. BUG=113688 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145874

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Total comments: 2

Patch Set 4 : Addressed comments (dubroy) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
markusheintz_
Please review this CL
8 years, 5 months ago (2012-07-10 11:19:32 UTC) #1
Patrick Dubroy
LGTM with the spelling fix. http://codereview.chromium.org/10701114/diff/5001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10701114/diff/5001/chrome/app/generated_resources.grd#newcode303 chrome/app/generated_resources.grd:303: + <ph name="PERMISSION_TYPE_LABLE">$1<ex>Plugins</ex></ph>: You ...
8 years, 5 months ago (2012-07-10 11:25:25 UTC) #2
markusheintz_
http://codereview.chromium.org/10701114/diff/5001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10701114/diff/5001/chrome/app/generated_resources.grd#newcode303 chrome/app/generated_resources.grd:303: + <ph name="PERMISSION_TYPE_LABLE">$1<ex>Plugins</ex></ph>: On 2012/07/10 11:25:25, dubroy wrote: > ...
8 years, 5 months ago (2012-07-10 11:32:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10701114/4003
8 years, 5 months ago (2012-07-10 11:32:47 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 13:44:51 UTC) #5 
Change committed as 145874

Powered by Google App Engine
This is Rietveld 408576698