Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 10701113: Place jars into the java/libs for native unittest apk (Closed)

Created:
8 years, 5 months ago by yongsheng
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Place jars into the java/libs for native unittest apk Complete the TODO for native unittests apk to place used jars into ${out.dir}/java/libs. Add the conditional check if there is no jar in that directory. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M testing/android/generate_native_test.py View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test_apk.xml View 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yongsheng
Please help review it, thanks.
8 years, 5 months ago (2012-07-10 09:38:55 UTC) #1
John Grabowski
I can OWNERS approval if Nilesh likes
8 years, 5 months ago (2012-07-10 18:13:14 UTC) #2
nilesh
On 2012/07/10 18:13:14, John Grabowski wrote: > I can OWNERS approval if Nilesh likes LGTM
8 years, 5 months ago (2012-07-10 18:20:23 UTC) #3
nilesh
On 2012/07/10 18:20:23, nileshagrawal1 wrote: > On 2012/07/10 18:13:14, John Grabowski wrote: > > I ...
8 years, 5 months ago (2012-07-10 18:20:36 UTC) #4
John Grabowski
Owners LGTM
8 years, 5 months ago (2012-07-10 18:27:15 UTC) #5
yongsheng
ok, thank all of you.
8 years, 5 months ago (2012-07-11 01:14:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10701113/1
8 years, 5 months ago (2012-07-11 01:15:34 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 02:32:34 UTC) #8
Change committed as 146034

Powered by Google App Engine
This is Rietveld 408576698