Issue 10701099: Make sure the bubbles are positioned relative to the content-area

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701099: Make sure the bubbles are positioned relative to the content-area (Closed)

Created:
8 years, 5 months ago by Cem Kocagil

Modified:
8 years, 5 months ago

Reviewers:
Dan Beam, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Make sure the bubbles are positioned relative to the content-area BUG=136080 TEST=Try the steps in the bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145843

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/shared/css/overlay.css	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Dan Beam

hmmm, this seems to work (applied locally) but it clips stuff that might've previously stuck ...

8 years, 5 months ago (2012-07-07 04:44:58 UTC) #2

Evan Stade

an unfortunate side effect but I'd say it's ok. Without this patch clipping is also ...

8 years, 5 months ago (2012-07-09 20:38:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cem.kocagil@gmail.com/10701099/1

8 years, 5 months ago (2012-07-10 04:03:54 UTC) #6

Change committed as 145843