Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4704)

Unified Diff: chrome/browser/browsing_data_remover.cc

Issue 10701094: Don't keep file system directories around if they contain unrelated files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: error message Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data_remover.h ('k') | webkit/fileapi/obfuscated_file_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data_remover.cc b/chrome/browser/browsing_data_remover.cc
index 0c42575a05185de7b85d0e79227ef227d89431a4..08bebbc39eae3b2e3d1c4d81ddd53bef13efd3f2 100644
--- a/chrome/browser/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data_remover.cc
@@ -785,7 +785,7 @@ void BrowsingDataRemover::OnGotQuotaManagedOrigins(
origin->GetOrigin(), type,
BrowsingDataRemover::GenerateQuotaClientMask(remove_mask_),
base::Bind(&BrowsingDataRemover::OnQuotaManagedOriginDeletion,
- base::Unretained(this)));
+ base::Unretained(this), origin->GetOrigin(), type));
}
--quota_managed_storage_types_to_delete_count_;
@@ -793,12 +793,13 @@ void BrowsingDataRemover::OnGotQuotaManagedOrigins(
}
void BrowsingDataRemover::OnQuotaManagedOriginDeletion(
+ const GURL& origin,
+ quota::StorageType type,
quota::QuotaStatusCode status) {
DCHECK_GT(quota_managed_origins_to_delete_count_, 0);
if (status != quota::kQuotaStatusOk) {
- // TODO(mkwst): We should add the GURL to StatusCallback; this is a pretty
- // worthless error message otherwise.
- DLOG(ERROR) << "Couldn't remove origin. Status: " << status;
+ DLOG(ERROR) << "Couldn't remove data of type " << type << " for origin "
+ << origin << ". Status: " << status;
}
--quota_managed_origins_to_delete_count_;
« no previous file with comments | « chrome/browser/browsing_data_remover.h ('k') | webkit/fileapi/obfuscated_file_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698