Add dummy browser::CreateWebContentsViewDelegate() for Android.

Add dummy browser::CreateWebContentsViewDelegate() for Android.

This is part of the unit_tests linking effort.

This will later have to be implemented (upstreamed) properly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145891

[Nico, 2012-07-04 16:14:54]

lgtm

https://chromiumcodereview.appspot.com/10701092/diff/1/chrome/browser/ui/andr...
File
chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
(right):

https://chromiumcodereview.appspot.com/10701092/diff/1/chrome/browser/ui/andr...
chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc:16:
NOTIMPLEMENTED();
Should you have tracking bugs for features that you do plan to implement? Then
you could add a comment like "// http://crbug.com/BUGNR" here, and if people
want to talk about that work they could use that bug for that.

(This is fairly common practice in chromium land.)

[Philippe, 2012-07-05 09:24:09]

Thanks Nico. I created a bug tracking that.

https://chromiumcodereview.appspot.com/10701092/diff/1/chrome/browser/ui/andr...
File
chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
(right):

https://chromiumcodereview.appspot.com/10701092/diff/1/chrome/browser/ui/andr...
chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc:16:
NOTIMPLEMENTED();
On 2012/07/04 16:14:54, Nico wrote:
> Should you have tracking bugs for features that you do plan to implement? Then
> you could add a comment like "// http://crbug.com/BUGNR%22 here, and if people
> want to talk about that work they could use that bug for that.
> 
> (This is fairly common practice in chromium land.)

Done.

[commit-bot: I haz the power, 2012-07-05 09:24:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10701092/4001

[commit-bot: I haz the power, 2012-07-05 09:24:43]

Presubmit check for 10701092-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Philippe, 2012-07-05 09:35:19]

On 2012/07/05 09:24:43, I haz the power (commit-bot) wrote:
> Presubmit check for 10701092-4001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for files in these directories:
>     chrome/browser/ui
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!

+sky

[Yaron, 2012-07-10 00:49:11]

lgtm

sky's OOO so adding ben

[Ben Goodger (Google), 2012-07-10 15:08:53]

lgtm

[commit-bot: I haz the power, 2012-07-10 15:14:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10701092/4001

[commit-bot: I haz the power, 2012-07-10 16:42:20]

Change committed as 145891