lib/compiler/implementation/apiimpl.dart - Issue 10701091: Dartdoc and Apidoc updated to use dart2js through the mirror system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/apiimpl.dart

Issue 10701091: Dartdoc and Apidoc updated to use dart2js through the mirror system. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixed cf. rnystrom's comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/apiimpl.dart

diff --git a/lib/compiler/implementation/apiimpl.dart b/lib/compiler/implementation/apiimpl.dart

index 8d6c88c36860ae6a0b300901888e829b91179b11..73a2ab718ac82568a2e2cbad373af6624bf0fd2b 100644

--- a/lib/compiler/implementation/apiimpl.dart

+++ b/lib/compiler/implementation/apiimpl.dart

@@ -105,7 +105,9 @@ class Compiler extends leg.Compiler {

if (kind === api.Diagnostic.ERROR || kind === api.Diagnostic.CRASH) {

compilationFailed = true;

}

- if (span === null) {

+ // [:span.uri:] might be [:null:] in case of a [Script] with no [uri]. For

ahe 2012/08/02 19:56:23 Actually, span.uri may not be null...

+ // instance in the [Types] constructor in typechecker.dart.

ahe 2012/08/02 19:56:23 ... because Types shouldn't do that :-)

+ if (span === null || span.uri === null) {

handler(null, null, null, message, kind);

} else {

handler(translateUri(span.uri, null), span.begin, span.end,

« no previous file with comments | « no previous file | lib/compiler/implementation/compiler.dart » ('j') | lib/compiler/implementation/compiler.dart » ('J')