Dartdoc and Apidoc updated to use dart2js through the mirror system.

lib/dartdoc/utils.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Generic utility functions.
 
 /** Turns [name] into something that's safe to use as a file name. */
 String sanitize(String name) => name.replaceAll(':', '_').replaceAll('/', '_');
 
 /** Returns the number of times [search] occurs in [text]. */
@@ skipping 29 matching lines @@
   var start;
   for (start = 0; start < Math.min(indentation, text.length); start++) {
     // Stop if we hit a non-whitespace character.
     if (text[start] != ' ') break;
   }
 
   return text.substring(start);
 }
 
 /** Sorts the map by the key, doing a case-insensitive comparison. */
-List orderByName(Map<String, Dynamic> map) {
-  List keys = map.getKeys();
-  keys.sort((a, b) {
+List orderByName(List list) {

[Lasse Reichstein Nielsen, 2012/07/09 10:39:33]

Put a generic type on the List types here. It's part of the interface contract. 
It also means I'll actually have a clue what the type of its elements are,
because it isn't mentioned ANYWHERE in this method.

And add types everywhere else too, please!!! It helps reading for me. 
Only ever use "var" when the RHS is a constructor call. Otherwise it is not
clear what type is expected, and I can't read the following code.

[Johnni Winther, 2012/07/09 14:57:18]

Done.

+  final elements = [];
+  for (var element in list) {
+    elements.add(element);
+  }

[Lasse Reichstein Nielsen, 2012/07/09 10:39:33]

final elements = new List<whateveritis>.from(list);

[Johnni Winther, 2012/07/09 14:57:18]

Done.

+  elements.sort((a, b) {
     // Hack: make sure $dom methods show up last in the list not first.
     String transformName(String name) =>
       name.toUpperCase().replaceFirst(const RegExp('\\\$DOM_'), 'zzzz');

[Lasse Reichstein Nielsen, 2012/07/09 10:39:33]

Use raw strings for regexp literals: const RegExp(@'\$DOM').

This seems uncredibly slow - you create two new strings *per comparison*. Try:

(a,b) {
  bool doma = a.indexOf(@"$DOM") >= 0;
  bool domb = a.indexOf(@"$DOM") >= 0;
  return doma == domb ? a.compareTo(b) : doma ? 1 : -1;
}

(Or, if the "$DOM" is always at a specific position, you might be able to use
.startsWith instead of .indexOf, or use lastIndexOf it's usually closer to the
end than to the start.

[Johnni Winther, 2012/07/09 14:57:18]

Done.

 
-    return transformName(a).compareTo(transformName(b));
+    return transformName(a.simpleName()).compareTo(

[kasperl, 2012/07/06 12:40:41]

Maybe do the transform before calling compareTo and use two extra local
variables?

[Johnni Winther, 2012/07/09 14:57:18]

Done.

+           transformName(b.simpleName()));
   });
-  final values = [];
-  for (var k in keys) {
-    values.add(map[k]);
-  }
-  return values;
+  return elements;
 }
 
 /**
  * Joins [items] into a single, comma-separated string using [conjunction].
  * E.g. `['A', 'B', 'C']` becomes `"A, B, and C"`.
  */
 String joinWithCommas(List<String> items, [String conjunction = 'and']) {
   if (items.length == 1) return items[0];
   if (items.length == 2) return "${items[0]} $conjunction ${items[1]}";
-  return Strings.join(items.getRange(0, items.length - 1), ', ') +
-    ', $conjunction ' + items[items.length - 1];
+  return '${Strings.join(items.getRange(0, items.length - 1), ', ')}'
+    ', $conjunction ${items[items.length - 1]}';
 }
+
+void writeString(File file, String text) {
+  var randomAccessFile = file.openSync(FileMode.WRITE);
+  randomAccessFile.writeStringSync(text);
+  randomAccessFile.closeSync();
+}