Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 10701080: Prevent crash when trying to dismiss an already dismissed infobar. (Closed)

Created:
8 years, 5 months ago by qsr
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Prevent crash when trying to dismiss an already dismissed infobar. The owner of an infobar delegate might be NULL if the infobar is already in the process of being deleted. Checking for this before asking it to dismiss in the auto-login infobar. TEST=None BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145896

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/auto_login_info_bar_delegate.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
qsr
8 years, 5 months ago (2012-07-03 11:06:11 UTC) #1
qsr
Changing reviewer as sky is OOO
8 years, 5 months ago (2012-07-10 09:07:36 UTC) #2
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10701080/diff/1/chrome/browser/ui/auto_login_info_bar_delegate.cc File chrome/browser/ui/auto_login_info_bar_delegate.cc (right): http://codereview.chromium.org/10701080/diff/1/chrome/browser/ui/auto_login_info_bar_delegate.cc#newcode225 chrome/browser/ui/auto_login_info_bar_delegate.cc:225: if (owner()) note here the circumstances when owner() ...
8 years, 5 months ago (2012-07-10 15:15:49 UTC) #3
qsr
http://codereview.chromium.org/10701080/diff/1/chrome/browser/ui/auto_login_info_bar_delegate.cc File chrome/browser/ui/auto_login_info_bar_delegate.cc (right): http://codereview.chromium.org/10701080/diff/1/chrome/browser/ui/auto_login_info_bar_delegate.cc#newcode225 chrome/browser/ui/auto_login_info_bar_delegate.cc:225: if (owner()) Done, and yes I agree it is ...
8 years, 5 months ago (2012-07-10 15:23:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/10701080/6
8 years, 5 months ago (2012-07-10 15:24:05 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 17:20:59 UTC) #6
Change committed as 145896

Powered by Google App Engine
This is Rietveld 408576698