Issue 10701058: Merge branch 'trunk' of http://git.chromium.org/git/chromium into autofill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701058: Merge branch 'trunk' of http://git.chromium.org/git/chromium into autofill (Closed)

Created:
8 years, 5 months ago by qinmin

Modified:
8 years, 5 months ago

Reviewers:
John Grabowski, Jay Civelli, jam, jcivelli

CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, dyu1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merge branch 'trunk' of http://git.chromium.org/git/chromium into autofill remove autofill impl from upstream Autofill involves calls to native view, so the dependency is not correct. If we want to upstream autofill_external_delegate_android, we have to introduce another delegate. Remove the code from upstream for now. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146021

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -22 lines)			Patch
D	chrome/browser/autofill/autofill_external_delegate_android.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
A +	chrome/browser/autofill/test_autofill_external_delegate_android.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jam

it's hard for me to review this since I'm not familiar with the code upstream. ...

8 years, 5 months ago (2012-07-03 00:59:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/10701058/1

8 years, 5 months ago (2012-07-11 00:12:58 UTC) #6

Change committed as 146021

Expand Messages | Collapse Messages