Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: ash/launcher/launcher_tooltip_manager_unittest.cc

Issue 10701051: Polish launcher tooltip visibility (2nd try). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/launcher/launcher_tooltip_manager.cc ('k') | ash/launcher/launcher_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/launcher/launcher_tooltip_manager_unittest.cc
diff --git a/ash/launcher/launcher_tooltip_manager_unittest.cc b/ash/launcher/launcher_tooltip_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0e428574d5034626c7c64e4b39a307308ad8b3dd
--- /dev/null
+++ b/ash/launcher/launcher_tooltip_manager_unittest.cc
@@ -0,0 +1,116 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/launcher/launcher_tooltip_manager.h"
+
+#include "ash/test/ash_test_base.h"
+#include "ash/wm/shelf_layout_manager.h"
+#include "ash/wm/window_util.h"
+#include "base/string16.h"
+#include "ui/views/widget/widget.h"
+
+namespace ash {
+namespace test {
+
+class LauncherTooltipManagerTest : public AshTestBase {
+ public:
+ LauncherTooltipManagerTest() {}
+ virtual ~LauncherTooltipManagerTest() {}
+
+ virtual void SetUp() OVERRIDE {
+ ash::test::AshTestBase::SetUp();
+
+ tooltip_manager_.reset(new internal::LauncherTooltipManager(
+ SHELF_ALIGNMENT_BOTTOM, Shell::GetInstance()->shelf()));
+ }
+
+ void ShowDelayed() {
+ dummy_anchor_.reset(new views::View);
+ tooltip_manager_->ShowDelayed(dummy_anchor_.get(), string16());
+ }
+
+ void ShowImmediately() {
+ dummy_anchor_.reset(new views::View);
+ tooltip_manager_->ShowImmediately(dummy_anchor_.get(), string16());
+ }
+
+ bool TooltipIsVisible() {
+ return tooltip_manager_->IsVisible();
+ }
+
+ bool IsTimerRunning() {
+ return tooltip_manager_->timer_.get() != NULL;
+ }
+
+ protected:
+ scoped_ptr<views::View> dummy_anchor_;
+ scoped_ptr<internal::LauncherTooltipManager> tooltip_manager_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(LauncherTooltipManagerTest);
+};
+
+TEST_F(LauncherTooltipManagerTest, ShowingBasics) {
+ // ShowDelayed() should just start the timer instead of showing immediately.
+ ShowDelayed();
+ EXPECT_FALSE(TooltipIsVisible());
+ EXPECT_TRUE(IsTimerRunning());
+
+ ShowImmediately();
+ EXPECT_TRUE(TooltipIsVisible());
+ EXPECT_FALSE(IsTimerRunning());
+}
+
+TEST_F(LauncherTooltipManagerTest, HideWhenShelfIsHidden) {
+ ShowImmediately();
+ ASSERT_TRUE(TooltipIsVisible());
+
+ // Create a full-screen window to hide the shelf.
+ scoped_ptr<views::Widget> widget(new views::Widget);
+ views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+ widget->Init(params);
+ widget->SetFullscreen(true);
+ widget->Show();
+
+ // Once the shelf is hidden, the tooltip should be invisible.
+ ASSERT_EQ(internal::ShelfLayoutManager::HIDDEN,
+ Shell::GetInstance()->shelf()->visibility_state());
+ EXPECT_FALSE(TooltipIsVisible());
+
+ // Do not show the view if the shelf is hidden.
+ ShowImmediately();
+ EXPECT_FALSE(TooltipIsVisible());
+
+ // ShowDelayed() doesn't even start the timer for the hidden shelf.
+ ShowDelayed();
+ EXPECT_FALSE(IsTimerRunning());
+}
+
+TEST_F(LauncherTooltipManagerTest, HideWhenShelfIsAutoHide) {
+ ShowImmediately();
+ ASSERT_TRUE(TooltipIsVisible());
+
+ internal::ShelfLayoutManager* shelf = Shell::GetInstance()->shelf();
+ shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
+ shelf->UpdateAutoHideState();
+ ASSERT_EQ(internal::ShelfLayoutManager::AUTO_HIDE_HIDDEN,
+ shelf->auto_hide_state());
+
+ // Tooltip visibility change for auto hide may take time.
+ EXPECT_TRUE(TooltipIsVisible());
+ RunAllPendingInMessageLoop();
+ EXPECT_FALSE(TooltipIsVisible());
+
+ // Do not show the view if the shelf is hidden.
+ ShowImmediately();
+ EXPECT_FALSE(TooltipIsVisible());
+
+ // ShowDelayed doesn't even run the timer for the hidden shelf.
+ ShowDelayed();
+ EXPECT_FALSE(IsTimerRunning());
+}
+
+} // namespace test
+} // namespace ash
« no previous file with comments | « ash/launcher/launcher_tooltip_manager.cc ('k') | ash/launcher/launcher_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698