Polish launcher tooltip visibility (2nd try).

Polish launcher tooltip visibility (2nd try).

Previous patch has broken win_aura build so reverted. This also fixes the build breaks.

Add ShelfLayoutManager::Observer for two cases:
- AutoHide: catches the auto hiding status to close the tooltip property
- FullScreen: catches the shelf visibility changes to close it too

Check the visibility of Shelf itself in case of tooltip showing.  Then the toolip
won't show if the shelf is hidden.

R=derat@chromium.org,davemoore@chromium.org
BUG=133551
TEST=manually done on lumpy, made sure aura_shell_unittests passed


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145837

[Daniel Erat, 2012-07-02 15:01:26]

The code LGTM, but can you add tests for this?

[Jun Mukai, 2012-07-04 09:06:57]

Added launcher_tooltip_manager_unittest.cc for the behaviors around visibility. 
Can you take another look at this?

[Daniel Erat, 2012-07-04 16:31:44]

LGTM.  Thanks!

http://codereview.chromium.org/10701051/diff/1014/ash/launcher/launcher_toolt...
File ash/launcher/launcher_tooltip_manager_unittest.cc (right):

http://codereview.chromium.org/10701051/diff/1014/ash/launcher/launcher_toolt...
ash/launcher/launcher_tooltip_manager_unittest.cc:55: // Show delayed do not
show at that time, but just run the timer to show.
nit: change to something like "ShowDelayed() should just start the timer instead
of showing immediately."

[Jun Mukai, 2012-07-05 02:33:15]

http://codereview.chromium.org/10701051/diff/1014/ash/launcher/launcher_toolt...
File ash/launcher/launcher_tooltip_manager_unittest.cc (right):

http://codereview.chromium.org/10701051/diff/1014/ash/launcher/launcher_toolt...
ash/launcher/launcher_tooltip_manager_unittest.cc:55: // Show delayed do not
show at that time, but just run the timer to show.
On 2012/07/04 16:31:44, Daniel Erat wrote:
> nit: change to something like "ShowDelayed() should just start the timer
instead
> of showing immediately."

Done.

[Jun Mukai, 2012-07-06 06:55:54]

Oops, I changed the code a bit.  Dan, could you take another look at this?

I noticed crashes happen in win_aura:aura_shell_unittests, which was caused
because ShelfLayoutManager can be released before LauncherTooltipManager is
released, so RemoveObserver(shelf_) in LauncherTooltipManager can lead crashes.
I introduced WillDeleteShelf() message in the Observer to prevent this.

On 2012/07/05 02:33:15, Jun Mukai wrote:
>
http://codereview.chromium.org/10701051/diff/1014/ash/launcher/launcher_toolt...
> File ash/launcher/launcher_tooltip_manager_unittest.cc (right):
> 
>
http://codereview.chromium.org/10701051/diff/1014/ash/launcher/launcher_toolt...
> ash/launcher/launcher_tooltip_manager_unittest.cc:55: // Show delayed do not
> show at that time, but just run the timer to show.
> On 2012/07/04 16:31:44, Daniel Erat wrote:
> > nit: change to something like "ShowDelayed() should just start the timer
> instead
> > of showing immediately."
> 
> Done.

[Daniel Erat, 2012-07-09 15:42:44]

lgtm

[commit-bot: I haz the power, 2012-07-10 02:34:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/10701051/9008

[commit-bot: I haz the power, 2012-07-10 03:40:23]

Change committed as 145837