chromeos/dbus/debug_daemon_client.cc - Issue 10701050: net: Implement canceling of all async operations in FileStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 10701050: net: Implement canceling of all async operations in FileStream. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/debug_daemon_client.cc

diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc

index 05d3b394ddce75695455ce808f9ccd1209c04f3f..0b509ffcb0efca9fb98b20dd4809e22e3e919c97 100644

--- a/chromeos/dbus/debug_daemon_client.cc

+++ b/chromeos/dbus/debug_daemon_client.cc

@@ -51,9 +51,7 @@ class PipeReader {

}

virtual ~PipeReader() {

- if (pipe_fd_[0] != -1)

- if (HANDLE_EINTR(close(pipe_fd_[0])) < 0)

- PLOG(ERROR) << "close[0]";

+ // Don't close pipe_fd_[0] as it's closed by data_stream_.

if (pipe_fd_[1] != -1)

if (HANDLE_EINTR(close(pipe_fd_[1])) < 0)

PLOG(ERROR) << "close[1]";