Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3665)

Unified Diff: chrome/browser/sessions/session_backend.cc

Issue 10701050: net: Implement canceling of all async operations in FileStream. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_backend.cc
diff --git a/chrome/browser/sessions/session_backend.cc b/chrome/browser/sessions/session_backend.cc
index 95cc5d1ec08480bf55cd767164c1e1ca258dfe18..8540a791ba9a06d52d369251e23332ebb2c7909a 100644
--- a/chrome/browser/sessions/session_backend.cc
+++ b/chrome/browser/sessions/session_backend.cc
@@ -349,9 +349,10 @@ bool SessionBackend::AppendCommandsToFile(net::FileStream* file,
SessionBackend::~SessionBackend() {
if (current_session_file_.get()) {
- // Close() performs file IO. crbug.com/112512.
+ // Destructor performs file IO because file is open in sync mode.
+ // crbug.com/112512.
base::ThreadRestrictions::ScopedAllowIO allow_io;
- current_session_file_->CloseSync();
+ current_session_file_.reset();
}
}

Powered by Google App Engine
This is Rietveld 408576698