chrome/browser/sessions/session_backend.cc - Issue 10701050: net: Implement canceling of all async operations in FileStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_backend.cc

Issue 10701050: net: Implement canceling of all async operations in FileStream. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sessions/session_backend.cc

diff --git a/chrome/browser/sessions/session_backend.cc b/chrome/browser/sessions/session_backend.cc

index 95cc5d1ec08480bf55cd767164c1e1ca258dfe18..8540a791ba9a06d52d369251e23332ebb2c7909a 100644

--- a/chrome/browser/sessions/session_backend.cc

+++ b/chrome/browser/sessions/session_backend.cc

@@ -349,9 +349,10 @@ bool SessionBackend::AppendCommandsToFile(net::FileStream* file,

SessionBackend::~SessionBackend() {

if (current_session_file_.get()) {

- // Close() performs file IO. crbug.com/112512.

+ // Destructor performs file IO because file is open in sync mode.

+ // crbug.com/112512.

base::ThreadRestrictions::ScopedAllowIO allow_io;

- current_session_file_->CloseSync();

+ current_session_file_.reset();

}