Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: sync/internal_api/sync_manager_impl.h

Issue 10701046: sync: Remove SyncManager::TestingMode in favour of InternalComponentsFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: now with more scope Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl.h
diff --git a/sync/internal_api/sync_manager_impl.h b/sync/internal_api/sync_manager_impl.h
index 783822d4c95ee833f9ab0dc7044758de5ea2166d..3b8dd1eaca8a02486e5dc901e809cb5144961297 100644
--- a/sync/internal_api/sync_manager_impl.h
+++ b/sync/internal_api/sync_manager_impl.h
@@ -46,7 +46,7 @@ class SyncManagerImpl : public SyncManager {
const SyncCredentials& credentials,
scoped_ptr<syncer::SyncNotifier> sync_notifier,
const std::string& restored_key_for_bootstrapping,
- TestingMode testing_mode,
+ scoped_ptr<InternalComponentsFactory> internal_components_factory,
syncer::Encryptor* encryptor,
syncer::UnrecoverableErrorHandler* unrecoverable_error_handler,
syncer::ReportUnrecoverableErrorFunction
@@ -110,11 +110,6 @@ class SyncManagerImpl : public SyncManager {
base::TimeDelta GetNudgeDelayTimeDelta(const syncer::ModelType& model_type);
- // Set the internal scheduler for testing purposes.
- // TODO(sync): Use dependency injection instead. crbug.com/133061
- void SetSyncSchedulerForTest(
- scoped_ptr<syncer::SyncScheduler> scheduler);
-
base::ThreadChecker thread_checker_;
// An opaque pointer to the nested private class.

Powered by Google App Engine
This is Rietveld 408576698