Make ShortcutsBackend a ProfileKeyedService.

chrome/browser/autocomplete/shortcuts_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/shortcuts_provider.h"
 
 #include <algorithm>
 #include <cmath>
 #include <map>
 #include <vector>
 
 #include "base/i18n/break_iterator.h"
 #include "base/i18n/case_conversion.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete.h"
 #include "chrome/browser/autocomplete/autocomplete_provider_listener.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/history_notifications.h"
 #include "chrome/browser/history/history_service_factory.h"
+#include "chrome/browser/history/shortcuts_backend_factory.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "googleurl/src/url_parse.h"
 
 namespace {
 
 class RemoveMatchPredicate {
  public:
   explicit RemoveMatchPredicate(const std::set<GURL>& urls)
       : urls_(urls) {
   }
   bool operator()(const AutocompleteMatch& match) {
     return urls_.find(match.destination_url) != urls_.end();
   }
  private:
   // Lifetime of the object is less than the lifetime of passed |urls|, so
   // it is safe to store reference.
   const std::set<GURL>& urls_;
 };
 
 }  // namespace
 
 ShortcutsProvider::ShortcutsProvider(AutocompleteProviderListener* listener,
                                      Profile* profile)
     : AutocompleteProvider(listener, profile, "ShortcutsProvider"),
       languages_(profile_->GetPrefs()->GetString(prefs::kAcceptLanguages)),
-      initialized_(false),
-      shortcuts_backend_(profile->GetShortcutsBackend()) {
-  if (shortcuts_backend_.get()) {
-    shortcuts_backend_->AddObserver(this);
-    if (shortcuts_backend_->initialized())
+      initialized_(false) {
+  scoped_refptr<history::ShortcutsBackend> backend =
+      ShortcutsBackendFactory::GetForProfile(profile_);
+  if (backend) {
+    backend->AddObserver(this);
+    if (backend->initialized())
       initialized_ = true;
   }
 }
 
 void ShortcutsProvider::Start(const AutocompleteInput& input,
                               bool minimal_changes) {
   matches_.clear();
 
   if ((input.type() == AutocompleteInput::INVALID) ||
       (input.type() == AutocompleteInput::FORCED_QUERY))
@@ skipping 34 matching lines @@
   // Delete the match from the history DB. This will eventually result in a
   // second call to DeleteShortcutsWithURLs(), which is harmless.
   HistoryService* const history_service =
       HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
 
   DCHECK(history_service && url.is_valid());
   history_service->DeleteURL(url);
 }
 
 ShortcutsProvider::~ShortcutsProvider() {
-  if (shortcuts_backend_.get())
-    shortcuts_backend_->RemoveObserver(this);
+  scoped_refptr<history::ShortcutsBackend> backend =
+      ShortcutsBackendFactory::GetForProfileIfExists(profile_);
+  if (backend)
+    backend->RemoveObserver(this);
 }
 
 void ShortcutsProvider::OnShortcutsLoaded() {
   initialized_ = true;
 }
 
 void ShortcutsProvider::DeleteMatchesWithURLs(const std::set<GURL>& urls) {
   std::remove_if(matches_.begin(), matches_.end(), RemoveMatchPredicate(urls));
   listener_->OnProviderUpdate(true);
 }
 
 void ShortcutsProvider::DeleteShortcutsWithURLs(const std::set<GURL>& urls) {
-  if (!shortcuts_backend_.get())
+  scoped_refptr<history::ShortcutsBackend> backend =
+      ShortcutsBackendFactory::GetForProfileIfExists(profile_);
+  if (!backend)
     return;  // We are off the record.
   for (std::set<GURL>::const_iterator url = urls.begin(); url != urls.end();
        ++url)
-    shortcuts_backend_->DeleteShortcutsWithUrl(*url);
+    backend->DeleteShortcutsWithUrl(*url);
 }
 
 void ShortcutsProvider::GetMatches(const AutocompleteInput& input) {
+  scoped_refptr<history::ShortcutsBackend> backend =
+      ShortcutsBackendFactory::GetForProfileIfExists(profile_);
+  if (!backend)
+    return;
   // Get the URLs from the shortcuts database with keys that partially or
   // completely match the search term.
   string16 term_string(base::i18n::ToLower(input.text()));
   DCHECK(!term_string.empty());
 
   for (history::ShortcutsBackend::ShortcutMap::const_iterator it =
-       FindFirstMatch(term_string);
-       it != shortcuts_backend_->shortcuts_map().end() &&
-            StartsWith(it->first, term_string, true); ++it)
+           FindFirstMatch(term_string, backend.get());
+       it != backend->shortcuts_map().end() &&
+           StartsWith(it->first, term_string, true); ++it)
     matches_.push_back(ShortcutToACMatch(input, term_string, it->second));
   std::partial_sort(matches_.begin(),
       matches_.begin() +
           std::min(AutocompleteProvider::kMaxMatches, matches_.size()),
       matches_.end(), &AutocompleteMatch::MoreRelevant);
   if (matches_.size() > AutocompleteProvider::kMaxMatches) {
     matches_.erase(matches_.begin() + AutocompleteProvider::kMaxMatches,
                    matches_.end());
   }
 }
@@ skipping 96 matching lines @@
     if (next_i_offset >= next_j_offset)
       ++j;
     if (next_j_offset >= next_i_offset)
       ++i;
   }
 
   return output;
 }
 
 history::ShortcutsBackend::ShortcutMap::const_iterator
-    ShortcutsProvider::FindFirstMatch(const string16& keyword) {
+    ShortcutsProvider::FindFirstMatch(const string16& keyword,
+                                      history::ShortcutsBackend* backend) {
+  DCHECK(backend);
   history::ShortcutsBackend::ShortcutMap::const_iterator it =
-      shortcuts_backend_->shortcuts_map().lower_bound(keyword);
+      backend->shortcuts_map().lower_bound(keyword);
   // Lower bound not necessarily matches the keyword, check for item pointed by
   // the lower bound iterator to at least start with keyword.
-  return ((it == shortcuts_backend_->shortcuts_map().end()) ||
+  return ((it == backend->shortcuts_map().end()) ||
     StartsWith(it->first, keyword, true)) ? it :
-    shortcuts_backend_->shortcuts_map().end();
+    backend->shortcuts_map().end();
 }
 
 // static
 int ShortcutsProvider::CalculateScore(
     const string16& terms,
     const history::ShortcutsBackend::Shortcut& shortcut) {
   DCHECK(!terms.empty());
   DCHECK_LE(terms.length(), shortcut.text.length());
 
   // The initial score is based on how much of the shortcut the user has typed.
@@ skipping 18 matching lines @@
   // (1.0 / each 5 additional hits), up to a maximum of 5x as long.
   const double kMaxDecaySpeedDivisor = 5.0;
   const double kNumUsesPerDecaySpeedDivisorIncrement = 5.0;
   double decay_divisor = std::min(kMaxDecaySpeedDivisor,
       (shortcut.number_of_hits + kNumUsesPerDecaySpeedDivisorIncrement - 1) /
       kNumUsesPerDecaySpeedDivisorIncrement);
 
   return static_cast<int>((base_score / exp(decay_exponent / decay_divisor)) +
       0.5);
 }
-
-void ShortcutsProvider::set_shortcuts_backend(
-    history::ShortcutsBackend* shortcuts_backend) {
-  DCHECK(shortcuts_backend);
-  shortcuts_backend_ = shortcuts_backend;
-  shortcuts_backend_->AddObserver(this);
-  if (shortcuts_backend_->initialized())
-    initialized_ = true;
-}