Make ShortcutsBackend a ProfileKeyedService.

chrome/browser/history/shortcuts_backend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/history/shortcuts_backend.h"
+#include "chrome/browser/history/shortcuts_backend_factory.h"
 #include "chrome/browser/history/shortcuts_database.h"
+#include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread.h"
 #include "sql/statement.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 namespace history {
 
 const base::TimeDelta kMaxRequestWaitTimeout = base::TimeDelta::FromSeconds(1);
 
 class ShortcutsBackendTest : public testing::Test,
                              public ShortcutsBackend::ShortcutsBackendObserver {
  public:
   ShortcutsBackendTest()
       : ui_thread_(BrowserThread::UI, &ui_message_loop_),
         db_thread_(BrowserThread::DB),
-        load_notified_(false) {}
+        load_notified_(false),
+        changed_notified_(false) {}
 
   void SetUp();
   void TearDown();
 
   virtual void OnShortcutsLoaded() OVERRIDE;
   virtual void OnShortcutsChanged() OVERRIDE;
 
   void InitBackend();
 
-  ScopedTempDir temp_dir_;
+  TestingProfile profile_;
   scoped_refptr<ShortcutsBackend> backend_;
   MessageLoopForUI ui_message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread db_thread_;
 
   bool load_notified_;
+  bool changed_notified_;
 };
 
 void ShortcutsBackendTest::SetUp() {
-  ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-  backend_ = new ShortcutsBackend(temp_dir_.path(), NULL);
+  db_thread_.Start();
+  ShortcutsBackendFactory::GetInstance()->SetTestingFactoryAndUse(
+      &profile_, &ShortcutsBackendFactory::GetForProfileForTesting);
+  backend_ = ShortcutsBackendFactory::GetForProfile(&profile_);
+  ASSERT_TRUE(backend_.get());
   backend_->AddObserver(this);
-  db_thread_.Start();
 }
 
 void ShortcutsBackendTest::TearDown() {
   backend_->RemoveObserver(this);
   db_thread_.Stop();
 }
 
 void ShortcutsBackendTest::OnShortcutsLoaded() {
   load_notified_ = true;
   MessageLoop::current()->Quit();
 }
 
 void ShortcutsBackendTest::OnShortcutsChanged() {
+  changed_notified_ = true;
 }
 
 void ShortcutsBackendTest::InitBackend() {
-  EXPECT_FALSE(load_notified_);
-  EXPECT_FALSE(backend_->initialized());
-  EXPECT_TRUE(backend_->Init());
+  ShortcutsBackend* backend = ShortcutsBackendFactory::GetForProfile(&profile_);
+  ASSERT_TRUE(backend);
+  ASSERT_FALSE(load_notified_);
+  ASSERT_FALSE(backend_->initialized());
   MessageLoop::current()->Run();
   EXPECT_TRUE(load_notified_);
   EXPECT_TRUE(backend_->initialized());
 }
 
 TEST_F(ShortcutsBackendTest, AddAndUpdateShortcut) {
   InitBackend();
+  EXPECT_FALSE(changed_notified_);
   ShortcutsBackend::Shortcut shortcut("BD85DBA2-8C29-49F9-84AE-48E1E90880DF",
       ASCIIToUTF16("goog"), GURL("http://www.google.com"),
       ASCIIToUTF16("Google"),
       AutocompleteMatch::ClassificationsFromString("0,1"),
       ASCIIToUTF16("Google"),
       AutocompleteMatch::ClassificationsFromString("0,1"), base::Time::Now(),
       100);
   EXPECT_TRUE(backend_->AddShortcut(shortcut));
+  EXPECT_TRUE(changed_notified_);
+  changed_notified_ = false;
 
   const ShortcutsBackend::ShortcutMap& shortcuts = backend_->shortcuts_map();
   ASSERT_TRUE(shortcuts.end() != shortcuts.find(shortcut.text));
   EXPECT_EQ(shortcut.id, shortcuts.find(shortcut.text)->second.id);
   EXPECT_EQ(shortcut.contents, shortcuts.find(shortcut.text)->second.contents);
   shortcut.contents = ASCIIToUTF16("Google Web Search");
   EXPECT_TRUE(backend_->UpdateShortcut(shortcut));
+  EXPECT_TRUE(changed_notified_);
   EXPECT_EQ(shortcut.id, shortcuts.find(shortcut.text)->second.id);
   EXPECT_EQ(shortcut.contents, shortcuts.find(shortcut.text)->second.contents);
 }
 
 TEST_F(ShortcutsBackendTest, DeleteShortcuts) {
   InitBackend();
   ShortcutsBackend::Shortcut shortcut1("BD85DBA2-8C29-49F9-84AE-48E1E90880DF",
       ASCIIToUTF16("goog"), GURL("http://www.google.com"),
       ASCIIToUTF16("Google"),
       AutocompleteMatch::ClassificationsFromString("0,1,4,0"),
@@ skipping 48 matching lines @@
   std::vector<std::string> deleted_ids;
   deleted_ids.push_back(shortcut3.id);
   deleted_ids.push_back(shortcut4.id);
 
   EXPECT_TRUE(backend_->DeleteShortcutsWithIds(deleted_ids));
 
   ASSERT_EQ(0U, shortcuts.size());
 }
 
 }  // namespace history