Refactor SyncedWindowDelegateAndroid into TabModel

chrome/browser/metrics/metrics_service.cc

Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index ad924096a76d121bc54aae83094f03479d22990c..559376f2e38e1296c1d90e6aba89beae0303e192 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -211,6 +211,10 @@
 #include <windows.h>  // Needed for STATUS_* codes
 #endif
 
+#if defined(OS_ANDROID)
+#include "chrome/browser/ui/android/tab_model/tab_model_list_android.h"
+#endif
+
 using base::Time;
 using content::BrowserThread;
 using content::ChildProcessData;
@@ -1853,7 +1857,11 @@ bool MetricsService::CanLogNotification(
   // We simply don't log anything to UMA if there is a single incognito
   // session visible. The problem is that we always notify using the orginal
   // profile in order to simplify notification processing.
+#if defined(OS_ANDROID)
+  return !TabModelListAndroid::IsOffTheRecordSessionActive();

[sky, 2012/07/16 23:07:30]

I would rather see a function in the browser namespace that does this. The
android implementation would call off to TabModelListAndroid, and the
non-android implementation would use BrowserList::IsOffTheRecordSessionActive.
Maybe put these in browser_otr_state.h, browser_otr_state.cc and
browser_otr_state_android.cc

[David Trainor- moved to gerrit, 2012/07/18 23:59:04]

Done.

[jar (doing other things), 2012/07/19 00:11:35]

I see the comment... and your "done," but don't see the change.

On 2012/07/18 23:59:04, dtrainor wrote:

+#else
   return !BrowserList::IsOffTheRecordSessionActive();
+#endif
 }
 
 void MetricsService::RecordBooleanPrefValue(const char* path, bool value) {