Issue 10701029: clean-up: Use an id instead of memory pointer string in webui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701029: clean-up: Use an id instead of memory pointer string in webui. (Closed)

Created:
8 years, 5 months ago by xiyuan

Modified:
8 years, 5 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

clean-up: Use an id instead of memory pointer string in webui. Clean up cookie and cert webui to use id instead of memory pointer hex string. BUG=134519 TEST=Verify cookie and cert webui is not using memory pointer hex value as js object id. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145197

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -151 lines)			Patch
M	chrome/browser/ui/webui/cookies_tree_model_util.h	View		3 chunks	+38 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/webui/cookies_tree_model_util.cc	View		5 chunks	+71 lines, -72 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/certificate_manager_handler2.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/certificate_manager_handler2.cc	View		13 chunks	+73 lines, -52 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/cookies_view_handler2.h	View	1	4 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/cookies_view_handler2.cc	View		6 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10701029/5001

8 years, 5 months ago (2012-07-02 20:08:22 UTC) #3

Change committed as 145197

Expand Messages | Collapse Messages