Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3749)

Unified Diff: chrome/browser/extensions/extension_i18n_api.cc

Issue 10701026: Use JSON schema compiler for i18n api (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moved to c/b/e/api/i18n Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_i18n_api.h ('k') | chrome/browser/extensions/extension_i18n_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_i18n_api.cc
diff --git a/chrome/browser/extensions/extension_i18n_api.cc b/chrome/browser/extensions/extension_i18n_api.cc
deleted file mode 100644
index d1b87080ccc92ff54045cb65acac7978e0363ca9..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/extension_i18n_api.cc
+++ /dev/null
@@ -1,55 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/extension_i18n_api.h"
-
-#include "base/string_piece.h"
-#include "base/utf_string_conversions.h"
-#include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/common/pref_names.h"
-
-// Errors.
-static const char kEmptyAcceptLanguagesError[] = "accept-languages is empty.";
-
-bool GetAcceptLanguagesFunction::RunImpl() {
- string16 acceptLanguages =
- UTF8ToUTF16(profile()->GetPrefs()->GetString(prefs::kAcceptLanguages));
- // Currently, there are 2 ways to set browser's accept-languages: through UI
- // or directly modify the preference file. The accept-languages set through
- // UI is guranteed to be valid, and the accept-languages string returned from
- // profile()->GetPrefs()->GetString(prefs::kAcceptLanguages) is guranteed to
- // be valid and well-formed, which means each accept-langauge is a valid
- // code, and accept-languages are seperatd by "," without surrrounding
- // spaces. But we do not do any validation (either the format or the validity
- // of the language code) on accept-languages set through editing preference
- // file directly. So, here, we're adding extra checks to be resistant to
- // crashes caused by data corruption.
- ListValue* result_languages = new ListValue();
- SetResult(result_languages);
- if (acceptLanguages.empty()) {
- error_ = kEmptyAcceptLanguagesError;
- return false;
- }
- size_t begin = 0;
- size_t end;
- while (1) {
- end = acceptLanguages.find(',', begin);
- if (end > begin) {
- // Guard against a malformed value with multiple "," in a row.
- string16 acceptLang = acceptLanguages.substr(begin, end - begin);
- result_languages->Append(Value::CreateStringValue(acceptLang));
- }
- begin = end + 1;
- // 'begin >= acceptLanguages.length()' to guard against a value
- // ending with ','.
- if (end == string16::npos || begin >= acceptLanguages.length())
- break;
- }
- if (result_languages->GetSize() == 0) {
- error_ = kEmptyAcceptLanguagesError;
- return false;
- }
- return true;
-}
« no previous file with comments | « chrome/browser/extensions/extension_i18n_api.h ('k') | chrome/browser/extensions/extension_i18n_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698