Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: tools/json_schema_compiler/test/crossref_unittest.cc

Issue 10701012: JSON Schema Compiler: Added event compilation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reworked Create functions and lots of tests. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/crossref_unittest.cc
diff --git a/tools/json_schema_compiler/test/crossref_unittest.cc b/tools/json_schema_compiler/test/crossref_unittest.cc
index cf7189e55c200962ed5aeb078991c7f8ca3a3201..a0fc836e1828b7ca8a8f61181239296311f90963 100644
--- a/tools/json_schema_compiler/test/crossref_unittest.cc
+++ b/tools/json_schema_compiler/test/crossref_unittest.cc
@@ -60,8 +60,11 @@ TEST(JsonSchemaCompilerCrossrefTest, GetTestType) {
new test::api::simple_api::TestType());
EXPECT_TRUE(
test::api::simple_api::TestType::Populate(*value, test_type.get()));
- scoped_ptr<Value> result(GetTestType::Result::Create(*test_type));
- EXPECT_TRUE(value->Equals(result.get()));
+
+ scoped_ptr<ListValue> results(GetTestType::Result::Create(*test_type));
+ DictionaryValue* result = NULL;
+ results->GetDictionary(0, &result);
not at google - send to devlin 2012/07/11 07:22:06 ASSERT_TRUE around this, otherwise result will be
Matt Tytel 2012/07/12 03:07:56 Done.
+ EXPECT_TRUE(value->Equals(result));
}
TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {

Powered by Google App Engine
This is Rietveld 408576698