Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5516)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 10701012: JSON Schema Compiler: Added event compilation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/dns/dns_api.cc ('k') | chrome/browser/extensions/api/record/record_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/permissions/permissions_api.cc
diff --git a/chrome/browser/extensions/api/permissions/permissions_api.cc b/chrome/browser/extensions/api/permissions/permissions_api.cc
index b798030c4036e2683308f719c078cc9cc5f57b00..e5e655579caf65043cf80412d829464f99ccc9a7 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api.cc
+++ b/chrome/browser/extensions/api/permissions/permissions_api.cc
@@ -59,15 +59,15 @@ bool ContainsPermissionsFunction::RunImpl() {
if (!permissions.get())
return false;
- SetResult(Contains::Result::Create(
- GetExtension()->GetActivePermissions()->Contains(*permissions)));
+ results_ = Contains::Results::Create(
+ GetExtension()->GetActivePermissions()->Contains(*permissions));
return true;
}
bool GetAllPermissionsFunction::RunImpl() {
scoped_ptr<Permissions> permissions =
helpers::PackPermissionSet(GetExtension()->GetActivePermissions());
- SetResult(GetAll::Result::Create(*permissions));
+ results_ = GetAll::Results::Create(*permissions);
return true;
}
@@ -101,12 +101,12 @@ bool RemovePermissionsFunction::RunImpl() {
PermissionSet::CreateIntersection(permissions.get(), required));
if (!intersection->IsEmpty()) {
error_ = kCantRemoveRequiredPermissionsError;
- SetResult(Remove::Result::Create(false));
+ results_ = Remove::Results::Create(false);
return false;
}
PermissionsUpdater(profile()).RemovePermissions(extension, permissions.get());
- SetResult(Remove::Result::Create(true));
+ results_ = Remove::Results::Create(true);
return true;
}
@@ -127,14 +127,14 @@ void RequestPermissionsFunction::InstallUIProceed() {
PermissionsUpdater perms_updater(profile());
perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
- SetResult(Request::Result::Create(true));
+ results_ = Request::Results::Create(true);
SendResponse(true);
Release(); // Balanced in RunImpl().
}
void RequestPermissionsFunction::InstallUIAbort(bool user_initiated) {
- SetResult(Request::Result::Create(false));
+ results_ = Request::Results::Create(false);
SendResponse(true);
Release(); // Balanced in RunImpl().
@@ -176,7 +176,7 @@ bool RequestPermissionsFunction::RunImpl() {
if (!GetExtension()->optional_permission_set()->Contains(
*requested_permissions_)) {
error_ = kNotInOptionalPermissionsError;
- SetResult(Request::Result::Create(false));
+ results_ = Request::Results::Create(false);
return false;
}
@@ -187,7 +187,7 @@ bool RequestPermissionsFunction::RunImpl() {
if (granted.get() && granted->Contains(*requested_permissions_)) {
PermissionsUpdater perms_updater(profile());
perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
- SetResult(Request::Result::Create(true));
+ results_ = Request::Results::Create(true);
SendResponse(true);
return true;
}
« no previous file with comments | « chrome/browser/extensions/api/dns/dns_api.cc ('k') | chrome/browser/extensions/api/record/record_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698