Fix certificate manager buttons never becoming clickable.

Fix certificate manager buttons never becoming clickable.

Add some simple tests.

BUG=134519, 136864
TEST=open cert manager, select a cert, try to view/delete/etc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146920

[mattm, 2012-07-13 02:29:06]

Expanded the test a bit to test the delete button functionality too.

[Evan Stade, 2012-07-13 06:28:21]

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/resources/o...
File chrome/browser/resources/options2/certificate_tree.js (right):

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/resources/o...
chrome/browser/resources/options2/certificate_tree.js:25: }
no curlies. In fact I don't think you even need the check.

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options2/certificate_manager_browsertest.js
(right):

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:102: 
extra \n

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:119:
CertificateManager.onPopulateTree(
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...

inline anonymous function bodies align with the start of the block, they do not
follow normal indentation conventions. This is relevant in many places in this
file.

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:145:
assertEquals(this.browsePreload, document.location.href);
this is too much indent by a lot.

[mattm, 2012-07-13 20:06:27]

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/resources/o...
File chrome/browser/resources/options2/certificate_tree.js (right):

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/resources/o...
chrome/browser/resources/options2/certificate_tree.js:25: }
On 2012/07/13 06:28:21, Evan Stade wrote:
> no curlies. 

done

> In fact I don't think you even need the check.

I get a "[32655:32655:1378492526131:ERROR:CONSOLE(49)] "Uncaught TypeError:
Cannot call method 'replace' of undefined", source:
chrome://resources/js/util.js (49)" error if I remove the check, but I didn't
investigate.

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options2/certificate_manager_browsertest.js
(right):

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:102: 
On 2012/07/13 06:28:21, Evan Stade wrote:
> extra \n

Done.

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:119:
CertificateManager.onPopulateTree(
On 2012/07/13 06:28:21, Evan Stade wrote:
>
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...
> 
> inline anonymous function bodies align with the start of the block, they do
not
> follow normal indentation conventions. This is relevant in many places in this
> file.

Done.

http://codereview.chromium.org/10700195/diff/11008/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:145:
assertEquals(this.browsePreload, document.location.href);
On 2012/07/13 06:28:21, Evan Stade wrote:
> this is too much indent by a lot.

Done.

[Evan Stade, 2012-07-16 18:25:46]

lgtm

http://codereview.chromium.org/10700195/diff/13002/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options2/certificate_manager_browsertest.js
(right):

http://codereview.chromium.org/10700195/diff/13002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:61: // it. 
This simulates what will be displayed if retrieving the cert list
just one space after .

[mattm, 2012-07-16 20:10:33]

http://codereview.chromium.org/10700195/diff/13002/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options2/certificate_manager_browsertest.js
(right):

http://codereview.chromium.org/10700195/diff/13002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options2/certificate_manager_browsertest.js:61: // it. 
This simulates what will be displayed if retrieving the cert list
On 2012/07/16 18:25:46, Evan Stade wrote:
> just one space after .

Done.

[commit-bot: I haz the power, 2012-07-16 20:10:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/10700195/19001

[commit-bot: I haz the power, 2012-07-16 21:26:44]

Try job failure for 10700195-19001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-16 21:50:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/10700195/19001

[commit-bot: I haz the power, 2012-07-16 23:08:11]

Change committed as 146920