Issue 10700160: Refactor copying of maps and descriptor arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700160: Refactor copying of maps and descriptor arrays. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactor copying of maps and descriptor arrays. Mainly ensure we don't copy descriptor arrays we'll throw away immediately afterwards. Committed: https://code.google.com/p/v8/source/detail?r=12044

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -131 lines)			Patch
M	src/factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	13 chunks	+106 lines, -110 lines	2 comments	Download
M	src/runtime.cc	View	1 chunk	+6 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

8 years, 5 months ago (2012-07-11 14:17:52 UTC) #2

LGTM with comments

https://chromiumcodereview.appspot.com/10700160/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10700160/diff/1/src/objects.cc#newcode...
src/objects.cc:1570: 
nit: one space

https://chromiumcodereview.appspot.com/10700160/diff/1/src/objects.cc#newcode...
src/objects.cc:1580: { MaybeObject* maybe_new_transitions =
map()->AddTransition(name, new_map);
Please remove

Expand Messages | Collapse Messages