Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 10700158: Get base_unittests closer to compiling for iOS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@all-ios-tweak
Visibility:
Public.

Description

Get base_unittests closer to compiling for iOS MessageLoop still needs to be brought on line in order for this to link, but it's much closer to working. TBR= BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146119

Patch Set 1 #

Patch Set 2 : Comment fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M base/base.gyp View 1 3 chunks +29 lines, -2 lines 2 comments Download
M base/test/test_suite.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
This assumes some of my other in-flight CLs have landed, but since the target currently ...
8 years, 5 months ago (2012-07-11 08:53:25 UTC) #1
rohitrao (ping after 24h)
https://chromiumcodereview.appspot.com/10700158/diff/3001/base/base.gyp File base/base.gyp (right): https://chromiumcodereview.appspot.com/10700158/diff/3001/base/base.gyp#newcode633 base/base.gyp:633: 'target_conditions': [ Why does this need to be in ...
8 years, 5 months ago (2012-07-11 12:05:10 UTC) #2
stuartmorgan
https://chromiumcodereview.appspot.com/10700158/diff/3001/base/base.gyp File base/base.gyp (right): https://chromiumcodereview.appspot.com/10700158/diff/3001/base/base.gyp#newcode633 base/base.gyp:633: 'target_conditions': [ On 2012/07/11 12:05:10, rohitrao wrote: > Why ...
8 years, 5 months ago (2012-07-11 12:56:56 UTC) #3
rohitrao (ping after 24h)
lgtm
8 years, 5 months ago (2012-07-11 13:32:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10700158/3001
8 years, 5 months ago (2012-07-11 13:39:23 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 15:09:12 UTC) #6
Change committed as 146119

Powered by Google App Engine
This is Rietveld 408576698