Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10700155: Remove #pragma once from chrome/browser/{printing,safe_browsing,prefs,bookmarks,autocomplete} (Closed)

Created:
8 years, 5 months ago by awong
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove #pragma once from chrome/browser/{printing,safe_browsing,prefs,bookmarks,autocomplete} For context: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -110 lines) Patch
M chrome/browser/autocomplete/autocomplete_classifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_field_trial.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_log.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_listener.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_contents_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/url_prefix.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/base_bookmark_model_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_expanded_state_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_helpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_index.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/default_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/overlay_user_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_change_registrar.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_member.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_model_associator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_notifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_notifier_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_observer_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_mock_builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_set_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/proxy_config_dictionary.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/proxy_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/scoped_user_pref_update.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/session_startup_pref.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/testing_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/value_map_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/background_printing_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_url.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/virtual_driver_install_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_error_dialog.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_worker_owner.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_context_menu_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_data_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_unit_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/printer_query.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/bloom_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/chunk_range.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/prefix_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/signature_util.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
awong
gene: printing shess: safe_browsing sky: bookmarks,autocomplete
8 years, 5 months ago (2012-07-11 02:07:45 UTC) #1
awong
8 years, 5 months ago (2012-07-11 02:10:53 UTC) #2
gene
8 years, 5 months ago (2012-07-11 07:26:24 UTC) #3
gene
lgtm for printing
8 years, 5 months ago (2012-07-11 07:26:48 UTC) #4
Scott Hess - ex-Googler
8 years, 5 months ago (2012-07-11 14:40:24 UTC) #5 
safe_browsing LGTM.

Powered by Google App Engine
This is Rietveld 408576698