Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10700154: Remove #pragma once from sync (Closed)

Created:
8 years, 5 months ago by awong
Modified:
8 years, 5 months ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Remove #pragma once from sync Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -144 lines) Patch
M sync/api/fake_syncable_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/sync_change.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/sync_change_processor.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/sync_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/sync_error.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/sync_error_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/sync_error_factory_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/api/syncable_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/all_status.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/apply_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/build_commit_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/cleanup_disabled_types_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/commit.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/conflict_resolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/download_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/get_commit_ids_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/model_changing_syncer_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/net/server_connection_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/net/url_translator.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/nudge_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/process_commit_response_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/process_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/resolve_conflicts_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/store_timestamps_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/sync_engine_event.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/sync_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer_proto_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncproto.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/throttled_data_type_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/traffic_logger.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/traffic_recorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/update_applicator.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/verify_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/change_reorder_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/js_mutation_event_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/base/enum_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/base/model_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/base/model_type_payload_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/base/model_type_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/base_node.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/base_transaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/configure_reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/engine/passive_model_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/engine/polling_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/http_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/http_post_provider_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/http_post_provider_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/read_node.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/sessions/model_neutral_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/sessions/sync_source_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/test/test_user_share.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/user_share.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/experiments.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/immutable.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/report_unrecoverable_error_function.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/syncer_error.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/unrecoverable_error_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/unrecoverable_error_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/util/weak_handle.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/public/write_node.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/syncapi_server_connection_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_arg_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_event_details.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_event_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_reply_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/js_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/js/sync_js_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/chrome_invalidation_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/chrome_system_resources.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/invalidation_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/mock_sync_notifier_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/notifications_disabled_reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/push_client_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/registration_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/state_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/notifier/sync_notifier_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/protocol/proto_enum_conversions.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/protocol/proto_value_conversions.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/protocol/sync_protocol_error.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/ordered_commit_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/session_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/status_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/sync_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/sync_session_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/base_transaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/blob.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/dir_open_result.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/directory.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/directory_backing_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/directory_change_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/entry.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/entry_kernel.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/in_memory_directory_backing_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/mutable_entry.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/nigori_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/on_disk_directory_backing_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/read_transaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/scoped_kernel_lock.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/syncable-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/syncable_changes_version.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/syncable_columns.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/syncable_enum_conversions.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/syncable_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/syncable_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/transaction_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/write_transaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/write_transaction_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/engine/fake_model_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/engine/syncer_command_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/engine/test_directory_setter_upper.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/engine/test_id_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/engine/test_syncable_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/fake_encryptor.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/fake_extensions_activity_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/null_directory_change_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/null_transaction_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/sessions/test_scoped_session_event_listener.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/test_directory_backing_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/cryptographer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/data_encryption_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/data_type_histogram.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/encryptor.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/extensions_activity_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/get_session_name.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/get_session_name_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/get_session_name_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/nigori.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/session_utils_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/test_unrecoverable_error_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/util/time.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
awong
8 years, 5 months ago (2012-07-11 01:21:58 UTC) #1
akalin
rubber stamp lgtm
8 years, 5 months ago (2012-07-11 01:43:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/10700154/1
8 years, 5 months ago (2012-07-11 05:35:33 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 07:09:07 UTC) #4 
Change committed as 146074

Powered by Google App Engine
This is Rietveld 408576698