Issue 10700149: Some small changes to make the vm dart:mirrors somewhat closer to the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700149: Some small changes to make the vm dart:mirrors somewhat closer to the (Closed)

Created:
8 years, 5 months ago by turnidge

Modified:
8 years, 5 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Some small changes to make the vm dart:mirrors somewhat closer to the source mirror implementation by Johnni. - Add the MirrorSystem interface - Add a simple TypeMirror Committed: https://code.google.com/p/dart/source/detail?r=9612

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -92 lines)			Patch
M	lib/mirrors/mirrors.dart	View	3 chunks	+58 lines, -26 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	3 chunks	+23 lines, -6 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	13 chunks	+53 lines, -38 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	7 chunks	+19 lines, -18 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_remote_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages