chromeos: Fix StartupBrowserCreatorImpl::Launch crash.

chromeos: Fix StartupBrowserCreatorImpl::Launch crash.

Previous fix r144228 does not fix the crash. It seems the crash is more likely
to be caused by user closing the app window in a nested message that runs by
synchronous session restore. Add an WebContentsCloseObserver to monitor the app
contents and skip focusing logic if it is closed.

BUG=134478
TEST=Verify the crash in 134478 no longer happens.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146027

[Ben Goodger (Google), 2012-07-10 21:13:22]

lgtm

http://codereview.chromium.org/10700145/diff/1/chrome/browser/ui/startup/star...
File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right):

http://codereview.chromium.org/10700145/diff/1/chrome/browser/ui/startup/star...
chrome/browser/ui/startup/startup_browser_creator_impl.cc:235:
DCHECK(!contents);
DCHECK(!contents_)?

[xiyuan, 2012-07-10 21:21:04]

http://codereview.chromium.org/10700145/diff/1/chrome/browser/ui/startup/star...
File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right):

http://codereview.chromium.org/10700145/diff/1/chrome/browser/ui/startup/star...
chrome/browser/ui/startup/startup_browser_creator_impl.cc:235:
DCHECK(!contents);
On 2012/07/10 21:13:22, Ben Goodger (Google) wrote:
> DCHECK(!contents_)?

Oops. Fixed now. :p

[commit-bot: I haz the power, 2012-07-11 00:46:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10700145/2003

[commit-bot: I haz the power, 2012-07-11 01:57:39]

Change committed as 146027

[Nikita (slow), 2012-07-11 11:06:00]

lgtm