Issue 10700141: Canonicalize CHROME_SRC variable on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700141: Canonicalize CHROME_SRC variable on Android (Closed)

Created:
8 years, 5 months ago by Sami

Modified:
8 years, 5 months ago

Reviewers:
John Grabowski, John Knottenbelt

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Canonicalize CHROME_SRC variable on Android If $PWD contains a symlink, build/android/envsetup.sh ends up setting CHROME_SRC to the same symlinked path. This breaks some utilities (e.g., grit) that work with absolute paths and expect them to be prefixed by CHROME_SRC. The fix is to set CHROME_SRC to the canonical absolute path of the current directory. BUG= TEST=cd $SYMLINKED_PATH; unset CHROME_SRC; . build/android/envsetup.sh; android_gyp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146097