chrome/browser/extensions/api/file_system/file_system_apitest.cc - Issue 10700136: Prettify output from chrome.fileSystem.getDisplayPath for POSIX profile directories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_apitest.cc

Issue 10700136: Prettify output from chrome.fileSystem.getDisplayPath for POSIX profile directories (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Includes specific fix for Mac OS X, which was excluded from the posix code specifically Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/file_system/file_system_apitest.cc

diff --git a/chrome/browser/extensions/api/file_system/file_system_apitest.cc b/chrome/browser/extensions/api/file_system/file_system_apitest.cc

index 4cdbe4ff503610119aeae3d8c7cd26ed8501fb66..0bc334da3a5cf8df4fe9f09d813f275b431ab32d 100644

--- a/chrome/browser/extensions/api/file_system/file_system_apitest.cc

+++ b/chrome/browser/extensions/api/file_system/file_system_apitest.cc

@@ -48,9 +48,14 @@ IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiGetDisplayPath) {

<< message_;

}

-#if defined(OS_WIN)

+#if defined(OS_WIN) || defined(OS_POSIX)

IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiGetDisplayPathPrettify) {

- ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(base::DIR_PROFILE,

+#if defined(OS_WIN)

+ int override = base::DIR_PROFILE;

+#elif defined(OS_POSIX)

+ int override = base::DIR_HOME;

+#endif

+ ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(override,

test_root_folder_, false));

FilePath test_file = test_root_folder_.AppendASCII("gold.txt");

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | no next file » | no next file with comments »