Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10700129: remoting/host: Fix cpplint warning of header guards. (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 5 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, dcheng, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

remoting/host: Fix cpplint warning of header guards. Found by: $ cpplint.py remoting/host/* 2>&1 | grep "guard has wrong" R=jamiewalch@chromium.org,alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145814

Patch Set 1 #

Total comments: 1

Patch Set 2 : rm #pragma once #

Total comments: 2

Patch Set 3 : forgot to remove one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M remoting/host/capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/clipboard.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/disconnect_window.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M remoting/host/local_input_monitor.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/local_input_monitor_thread_linux.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M remoting/host/local_input_monitor_thread_win.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M remoting/host/sighup_listener_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/signaling_connector.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/verify_config_window_win.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/wts_console_observer_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
8 years, 5 months ago (2012-07-09 00:23:08 UTC) #1
alexeypa (please no reviews)
http://codereview.chromium.org/10700129/diff/1/remoting/host/continue_window.h File remoting/host/continue_window.h (right): http://codereview.chromium.org/10700129/diff/1/remoting/host/continue_window.h#newcode7 remoting/host/continue_window.h:7: #pragma once #pragma once is against C++ style guide ...
8 years, 5 months ago (2012-07-09 16:22:36 UTC) #2
tfarina
On Mon, Jul 9, 2012 at 1:22 PM, <alexeypa@chromium.org> wrote: > > http://codereview.chromium.org/10700129/diff/1/remoting/host/continue_window.h > File ...
8 years, 5 months ago (2012-07-09 16:36:10 UTC) #3
alexeypa (please no reviews)
On 2012/07/09 16:36:10, tfarina wrote: > I can remove it if that is consistent among ...
8 years, 5 months ago (2012-07-09 16:56:24 UTC) #4
tfarina
On 2012/07/09 16:56:24, alexeypa wrote: > On 2012/07/09 16:36:10, tfarina wrote: > > I can ...
8 years, 5 months ago (2012-07-09 17:02:43 UTC) #5
alexeypa (please no reviews)
8 years, 5 months ago (2012-07-09 17:10:40 UTC) #6
lgtm once the last remaining "#pragma once" is gone.

http://codereview.chromium.org/10700129/diff/10001/remoting/host/local_input_...
File remoting/host/local_input_monitor_thread_win.h (right):

http://codereview.chromium.org/10700129/diff/10001/remoting/host/local_input_...
remoting/host/local_input_monitor_thread_win.h:35: // Overridden from
base::SimpleThread:
nit#1: Remove this comment. "OVERRIDE" already carries the same message.

nit#2: I think there should be a period at the end, not the colon.

http://codereview.chromium.org/10700129/diff/10001/remoting/host/signaling_co...
File remoting/host/signaling_connector.h (right):

http://codereview.chromium.org/10700129/diff/10001/remoting/host/signaling_co...
remoting/host/signaling_connector.h:7: #pragma once
Remove this pragma.

Powered by Google App Engine
This is Rietveld 408576698