Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 10700127: Do not wrap memory allocation routines when building Chromium with compiler-based ThreadSanitizer. (Closed)

Created:
8 years, 5 months ago by Alexander Potapenko
Modified:
8 years, 5 months ago
Reviewers:
brettw, agl
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, kcc2, dvyukov
Visibility:
Public.

Description

Do not wrap memory allocation routines when building Chromium with compiler-based ThreadSanitizer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145897

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/process_util_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
Brett: Please take a look. Kostya: FYI, I believe this is necessary to avoid crashes ...
8 years, 5 months ago (2012-07-08 14:25:38 UTC) #1
brettw
I'll give an owners LGTM rubberstamp but I think you should also get a review ...
8 years, 5 months ago (2012-07-10 05:42:48 UTC) #2
Alexander Potapenko
+agl Adam, can you please take a look?
8 years, 5 months ago (2012-07-10 07:12:59 UTC) #3
agl
lgtm
8 years, 5 months ago (2012-07-10 14:17:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/10700127/4001
8 years, 5 months ago (2012-07-10 15:42:44 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 17:21:05 UTC) #6
Change committed as 145897

Powered by Google App Engine
This is Rietveld 408576698