chrome/browser/extensions/extension_resource_protocols.cc - Issue 10700117: Replaced static URLRequestFileJob factory with non-static protocol handler for File jobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_resource_protocols.cc

Issue 10700117: Replaced static URLRequestFileJob factory with non-static protocol handler for File jobs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Made changes suggested by reviewers Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_protocols.cc ('k') | chrome/browser/profiles/off_the_record_profile_io_data.cc » ('j') | chrome/browser/profiles/profile_impl_io_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_resource_protocols.cc

diff --git a/chrome/browser/extensions/extension_resource_protocols.cc b/chrome/browser/extensions/extension_resource_protocols.cc

index 84907ce45efa7dafbe777dfbc2bf0488eeb2f30c..0a76fde410f3fcc43024a5e281c80637b157edf2 100644

--- a/chrome/browser/extensions/extension_resource_protocols.cc

+++ b/chrome/browser/extensions/extension_resource_protocols.cc

@@ -9,6 +9,7 @@

#include "chrome/common/chrome_paths.h"

#include "chrome/common/extensions/extension_file_util.h"

#include "content/public/browser/browser_thread.h"

+#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_file_job.h"

namespace {

@@ -16,7 +17,9 @@ namespace {

class ExtensionResourcesJob : public net::URLRequestFileJob {

public:

explicit ExtensionResourcesJob(net::URLRequest* request)

- : net::URLRequestFileJob(request, FilePath()),

+ : net::URLRequestFileJob(request,

+ FilePath(),

+ request->context()->network_delegate()),

mmenke 2012/08/16 14:54:31 While you're here, could you fix this indent? Sho

shalev 2012/08/16 15:07:25 Done.

thread_id_(content::BrowserThread::UI) {

}