Break Crankshaft into phases.

src/mips/lithium-mips.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2177 matching lines @@
 
 
 class LChunkBuilder;
 class LChunk: public LChunkBase {
  public:
   explicit LChunk(CompilationInfo* info, HGraph* graph)
       : LChunkBase(info, graph) { }
 
   int GetNextSpillIndex(bool is_double);
   LOperand* GetNextSpillSlot(bool is_double);
+
+  static LChunk* cast(LChunkBase* chunk_base) {
+    return reinterpret_cast<LChunk*>(chunk_base);

[danno, 2012/07/12 11:14:54]

I am not sure if this (and others in ia32/x64/ARM) add any value. Elsewhere in
the runtime, the cast function does additional runtime checks to make sure the
cast is valid, justifying the existence of the extra function. Here, no such
check is possible, so I think it's probably better/simpler/less code just to do
the static_cast directly in the LCodeGen constructor.

[sanjoy, 2012/07/12 11:34:18]

Done.

+  }
 };
 
 
 class LChunkBuilder BASE_EMBEDDED {
  public:
   LChunkBuilder(CompilationInfo* info, HGraph* graph, LAllocator* allocator)
       : chunk_(NULL),
         info_(info),
         graph_(graph),
         zone_(graph->zone()),
@@ skipping 140 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
 };
 
 #undef DECLARE_HYDROGEN_ACCESSOR
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_MIPS_LITHIUM_MIPS_H_