Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: utils/compiler/buildbot.py

Issue 10700113: Have a "fast" ie-windows bot and a slower ie-windows bot. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/buildbot.py
===================================================================
--- utils/compiler/buildbot.py (revision 9412)
+++ utils/compiler/buildbot.py (working copy)
@@ -181,10 +181,16 @@
os.chdir(DART_PATH)
if system.startswith('win') and runtime == 'ie':
+ # We don't do proper sharding on the IE bots, since the runtime is
+ # long for both. We have a "fast bot" and a "slow bot" that run specific
+ # tests instead.
+ for i in flags:
+ if i.startswith('--shard='):
+ bot_num = i.split('=')[1]
# There should not be more than one InternetExplorerDriver instance
# running at a time. For details, see
# http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
- flags = flags + ['-j1']
+ flags = filter(lambda(item): not item.startswith('--shard'), flags) + ['-j1']
ricow1 2012/07/05 11:10:39 you might also want to remove --shards to not have
Emily Fortuna 2012/07/05 12:01:28 this will remove both --shard= and --shards=
ricow1 2012/07/05 12:04:49 oh, .startswith, sorry
if system == 'linux' and runtime == 'chrome':
# TODO(ngeoffray): We should install selenium on the buildbot.
@@ -199,12 +205,24 @@
# that run the browser tests to cut down on the cycle time.
TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'], flags)
- # Run the default set of test suites.
- TestStep("dart2js", mode, system, 'dart2js', runtime, [], flags)
+ if not (system.startswith('win') and runtime == 'ie'):
+ # Run the default set of test suites.
+ TestStep("dart2js", mode, system, 'dart2js', runtime, [], flags)
- # TODO(kasperl): Consider running peg and css tests too.
- extras = ['dart2js_extra', 'dart2js_native']
- TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras, flags)
+ # TODO(kasperl): Consider running peg and css tests too.
+ extras = ['dart2js_extra', 'dart2js_native']
+ TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras, flags)
+ else:
+ if bot_num == '1':
+ TestStep("dart2js", mode, system, 'dart2js', runtime, ['html'], flags)
+ else:
+ TestStep("dart2js", mode, system, 'dart2js', runtime, ['dartc',
+ 'samples', 'standalone', 'corelib', 'co19', 'language', 'isolate',
+ 'vm', 'json', 'benchmark_smoke', 'dartdoc', 'utils', 'pub', 'lib'],
Emily Fortuna 2012/07/05 10:18:02 alternatively, instead of explicitly listing all o
+ flags)
+ extras = ['dart2js_extra', 'dart2js_native']
+ TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras,
+ flags)
elif compiler == 'frog':
TestStep("frog", mode, system, compiler, runtime, [], flags)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698